Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viz on the fly #40

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 56eabfd
✅ Deployment Preview URL: https://ProjectPythia.github.io/kerchunk-cookbook/_preview/40

@norlandrhagen norlandrhagen self-requested a review August 9, 2023 22:29
Copy link
Collaborator

@norlandrhagen norlandrhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the contribution. Just a few minor nits.

  • Could we update the Overview section to something like:
    This notebook will demonstrate how to use Kerchunk with hvPlot and Datashader to lazily visualize a reference dataset in a streaming fashion.

  • In some of the other case studies, there is a section that gives a bit of background on what dataset we are using. It might be nice to give a tiny background about the Climatology lab's gridMet dataset and add any attribution they might have/request.

Overall awesome example! It'll be great to add it to the cookbook.

@ahuang11
Copy link
Contributor Author

Thanks for reviewing; added your suggestions.

@norlandrhagen norlandrhagen merged commit 7d8c217 into ProjectPythia:main Aug 10, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants