Remove csv_kwargs from catalogue #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] main from ProjectPythia:main
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Merged
erogluorhan
approved these changes
Oct 17, 2024
|
@erogluorhan if you prefer I removed extra changes in #36 I'm not sure why the build preview leads to a 404. This is typical immediately after the link is posted by the actions bot, but it is taking longer than usual. |
|
I don't know either. I've approved the #36 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intake V2 removed some CSV support and seems to no longer can understand csv_kwargs. Without those arguments the csv is read successfully.
Pinning numpy was also required due to conflicting versions with Xarray.
There are some changes to the footer in this PR that were made to all passing cookbooks.
Closes #33