Add Gridding Cookbook to the gallery #159
Conversation
r-ford
requested review from
ktyle and
erogluorhan
and removed request for
a team
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
|
It looks like the issue is still there. |
|
The error log is not very helpful here. But I wonder if the gallery generator is choking on this line in the config file Maybe the fact that the title starts with |
|
After some local debugging, the reason turns out to be this line in the _gallery_info.yml file which has an empty tag: etc. Turns out our code doesn't know how to handle an empty set of tags. A simple workaround would be to remove the |
|
This should work. The gallery code already had a check for empty tags but there was a bug in it. It was checking to see if the first item in a list was |
| @@ -68,7 +68,7 @@ def generate_repo_dicts(all_items): | |||
| gallery_info_dict = yaml.safe_load(urllib.request.urlopen(gallery_info_url)) | |||
| thumbnail = gallery_info_dict["thumbnail"] | |||
| tag_dict = { | |||
| k: v for k, v in gallery_info_dict["tags"].items() if v[0] is not None | |||
| k: v for k, v in gallery_info_dict["tags"].items() if v is not None | |||
There was a problem hiding this comment.
Do we want to check for both v is not None and v[0] is not None?
There was a problem hiding this comment.
Can't hurt. I just implemented that in the latest push.
This cookbook was removed in #142