Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1354 support isomorphic data client APIs without prerender configuration option #1358

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #1354

Documentation

ProjectEvergreen/www.greenwoodjs.dev#154

Summary of Changes

  1. Add "fallback" support for using the isomorphic data client APIs without setting the prerender flag
  2. Add some test cases for content as data <script> setup blocks

@thescientist13 thescientist13 added bug Something isn't working documentation Greenwood specific docs CLI Content as Data labels Dec 22, 2024
@thescientist13 thescientist13 changed the title bug/issue 1354 isomorphic data client without prerendering bug/issue 1354 support isomorphic data client APIs without prerender configuration option Dec 22, 2024
@thescientist13 thescientist13 changed the title bug/issue 1354 support isomorphic data client APIs without prerender configuration option bug/issue 1354 support isomorphic data client APIs without prerender configuration option Dec 22, 2024
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like this is failing for SSR pages... (no CONTENT_STATE detected)
Screenshot 2024-12-27 at 1 41 40 PM

@thescientist13 thescientist13 force-pushed the bug/issue-1354-isomorphic-data-client-without-prerendering branch from 0ecb6f6 to 763f84c Compare December 28, 2024 14:54
@thescientist13 thescientist13 merged commit 083076c into master Dec 28, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1354-isomorphic-data-client-without-prerendering branch December 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI Content as Data documentation Greenwood specific docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data client not working on production builds (when not using prerender option)
1 participant