Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1338 better detection for external CSS import statements #1345

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 13, 2024

Related Issue

related to #1338

Noticed that CSS @import statements starting with //, eg: @import url('//fonts.googleapis.com/css?family=Raleway&display=swap'); was production a not found warning based on this change

//fonts.googleapis.com/css?family=Source+Sans+Pro&display=swap from file => file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-lit/test/cases/build.prerender.getting-started/src/styles/theme.css

Documentation

N / A

Summary of Changes

  1. Better detection for remote URLs in CSS @import

@thescientist13 thescientist13 added bug Something isn't working CLI labels Dec 13, 2024
@thescientist13 thescientist13 changed the title better detection for external CSS import statements bug/issue 1338 better detection for external CSS import statements Dec 13, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 13, 2024
@thescientist13 thescientist13 merged commit c068f2d into master Dec 14, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1338-fix-detelection-for-external-css-import-paths branch December 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.1 bug Something isn't working CLI v0.31.0
Projects
Development

Successfully merging this pull request may close these issues.

bare CSS @import specifiers are not resolving and bundling correctly
1 participant