Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the now extreme long time to pip install during gen doc, causing timeout failure on readthedoc #483

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Apr 12, 2024

It has been observed that gen doc takes a very long time to install multiple versions of nbformat, both locally and on readthedocs, on the latter the build fails due to 30 mins timeout.

It has been identified that the older the few Jupyter notebook related packages, with their older version for Python 3.8, strangely caused multiple versions of nbformat to be installed.

Removing the most Jupyter notebook related packages, except for myst-nb with newer version, reduced the gen doc time dramatically.

Removing App Sdk, example app and jupyter notebook requirments also further reduced the doc build time and has no impact on final doc.

@MMelQin MMelQin requested review from gigony and removed request for gigony April 12, 2024 21:13
Copy link

sonarcloud bot commented Apr 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gigony gigony removed their request for review April 13, 2024 01:25
@gigony gigony merged commit 3e3404e into main Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants