Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: Group the actors by their role type in the "select" lists #931

Merged
merged 2 commits into from
Jan 15, 2025
Merged

imp: Group the actors by their role type in the "select" lists #931

merged 2 commits into from
Jan 15, 2025

Conversation

marien-probesys
Copy link
Member

@marien-probesys marien-probesys commented Jan 15, 2025 •
edited
Loading

Related issue(s)

#925

How to test manually

  1. Add a user and an agent role to the same user in the same organization
  2. Open a ticket in this organization
  3. Verify that the actors in the select are grouped either by "Users" or "Agents"
  4. Verify that the user is in the agent list

Reviewer checklist

  • Code is manually tested
  • Permissions / authorizations are verified
  • New data can be imported
  • Interface works on both mobiles and big screens
  • Interface works in both light and dark modes
  • Interface works on both Firefox and Chrome
  • Accessibility has been tested
  • Translations are synchronized
  • Tests are up to date
  • Copyright notices are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

@marien-probesys
dev: Add support for optgroup to the multiselect component
c3af805
@marien-probesys
imp: Group the actors by their role type in the "select" lists
ed366c0 
When selecting a "requester" or an "observer", the user lists were
cluttered with the agents. It was painful to find the real users of the
organization.

Now, the actors are grouped either by "Users" or "Agents".
@marien-probesys marien-probesys merged commit ed366c0 into main Jan 15, 2025
6 checks passed
@marien-probesys marien-probesys deleted the 925/imp/group-actors-in-selects branch January 15, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marien-probesys