Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start connect hub #422

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Conversation

bhavya-taneja
Copy link
Contributor

Description:

i have added the name of the website i.e. Start Connect Hub in the navigation bar.

Issue No:

Required Fixes #325

Type of change

[X] Other (specify): enhancement

Screenshots / videos (if applicable)

Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Additional Comments:

kindly tell if any changes are required.

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for startconnect-hub ready!

Name Link
🔨 Latest commit 186215b
🔍 Latest deploy log https://app.netlify.com/sites/startconnect-hub/deploys/6669d3fe70ff670008b47752
😎 Deploy Preview https://deploy-preview-422--startconnect-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bhavya-taneja
Copy link
Contributor Author

@Priyaaa1 i am not able to understand the issue in my PR why is it failing these checks can you please help me.

@Priyaaa1
Copy link
Owner

Priyaaa1 commented Jun 9, 2024

@bhavya-taneja there was some issue with the deployment of the website, maybe that's the reason.
Kindly resolve the conflicts.

@Priyaaa1
Copy link
Owner

@bhavya-taneja your changes increased the height of the navbar too much and the dark mode toggle is not there

@bhavya-taneja
Copy link
Contributor Author

@Priyaaa1 i have done the changes required can you please check.
And regarding the dark mode toggle button its there and working but i guess there is some issue in the original repository as the toggle button is not visible in the originally deployed website as well
original website
image
website after my changes
image

@Priyaaa1
Copy link
Owner

@bhavya-taneja there should be not any space between "Start" and "Connect", it's "StartConnect Hub". And kindly decrease it's font size. The alignment is not looking proper.

@bhavya-taneja
Copy link
Contributor Author

@Priyaaa1 done a few changes..... kindly check it.

@Priyaaa1 Priyaaa1 added gssoc PR related to GSSoC'24 level1 labels Jun 13, 2024
@Priyaaa1 Priyaaa1 merged commit acaa51f into Priyaaa1:main Jun 13, 2024
4 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc PR related to GSSoC'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding "STARTCONNECT" in the navigation bar
2 participants