Support for hashed block network ID's #237
Conversation
src/bedrock/1.18/SubChunk.js
Outdated
| for (let i = 0; i < paletteSize; i++) { | ||
| const runtimeId = stream.readZigZagVarInt() | ||
| const block = this.registry.blocksByRuntimeId[runtimeId] | ||
| this.palette[storageLayer][i] = { stateId: runtimeId, ...block, count: 0 } |
There was a problem hiding this comment.
stateId and runtimeId are not the same, stateId should be set to block.stateId, runtimeId should be the runtimeId (that should also be inside the block object return by this.registry.blocksByRuntimeId[runtimeId])
There was a problem hiding this comment.
Should block.runtimeId be added to pblock? Or I can just do stateId: block.stateId? this.registry.blocksByRuntimeId = data.blockStates when hashes are not used
There was a problem hiding this comment.
blocksByRuntimeId should look the exact same as blocksByStateId with the only difference being the key for the map being a runtimeID as opposed to a stateID
There was a problem hiding this comment.
block.stateId doesnt seem to exsit, I can add it to pregestry by blocksByRuntimeId[pBlock.getHash(name, states)].stateId = stateId but then data.blocksByRuntimeId = data.blocksByStateId would not have that field, how should this be resolved?
There was a problem hiding this comment.
Hmm, it seems node-minecraft-data doesn't expose a .stateId. So it seem the options to fix are:
- add
.stateIdfield in node-mcdata on top of.minStateId/.defaultState(this kind of feels wrong as typically node-mcdata maps right from blocks.json) - add in prismarine-registry a
.stateIdfield to blocks objects inside blocksBy* (would require.mapcopying over mc-data block data) - add some separate map inside p-registry to map stateID <-> runtimeID (kind of messy to have many of these maps)
I'm not sure exactly best approach but 2 seems least problematic, cc @rom1504
There was a problem hiding this comment.
I can do second for now, then could be reviewed and decided
|
what is the state of this? do you know @extremeheat ? |
|
Should be working |
|
Blocked by PrismarineJS/prismarine-registry#33 |
No description provided.