Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bot.heldItem and bot.entity.equipment #3225

Merged
merged 4 commits into from
Dec 30, 2023

Conversation

szdytom
Copy link
Contributor

@szdytom szdytom commented Nov 2, 2023

Made bot.heldItem and bot.entity.equipment two getter functions. Note bot.entity.heldItem may still be incorrect, and that was fixed in PrismarineJS/prismarine-entity#73

Fixes #3224
Fixes #397

@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

can you add a test ?

@szdytom
Copy link
Contributor Author

szdytom commented Dec 20, 2023

I've added a external test.

@rom1504 rom1504 merged commit 9865ab7 into PrismarineJS:master Dec 30, 2023
19 checks passed
@szdytom szdytom deleted the fix-bot-helditem branch June 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

bot.heldItem sometimes desync bot.entity.equipment is always empty array
2 participants