-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go back to without popping each page #3048
Go back to without popping each page #3048
Conversation
@dansiegel As far as debugging goes, it seems to be working reasonably well. However, I am uncertain about the possible use cases and whether the behavior is truly correct. Additionally, I am unsure about the variations I should create in unit tests and struggling with deciding which class to target for unit tests (it should be the PageNavigationServiceFixture class, but it is not currently the subject of unit testing). I apologize for reaching out amidst your busy schedule, but I would appreciate any advice you can provide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to add Unit tests for the new APIs. It would also be good to update the E2E app for manual testing and validation.
Also would suggest you break this up into 2 PR's one for GoBack and one for NavigateFrom |
Thank you for your advice. |
@dansiegel |
Thanks for the PR @niimima |
Description of Change
Adding GoBackAsync methods without popping each page and NavigateFromAsync methods without recreating a page.
Bugs Fixed
API Changes
Added:
Changed:
Behavioral Changes
No changes. Only additions of features. We have added casts due to errors in existing extension methods, but there are no changes in behavior.
PR Checklist