GETP-308 fix: 피플 좋아요 여부 메소드에 member 객체 null 체크 추가 (#175)

Principes-Artis-Mechanicae · Oct 13, 2024 · dfe520c · dfe520c
1 parent fa35933
commit dfe520c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/main/java/es/princip/getp/api/controller/people/query/PeopleQueryController.java b/src/main/java/es/princip/getp/api/controller/people/query/PeopleQueryController.java
@@ -37,7 +37,7 @@ public class PeopleQueryController extends ControllerSupport {
      * @return 피플 ID에 해당되는 피플 상세 정보
      */
     @GetMapping("/{peopleId}")
-    public ResponseEntity<? extends ApiSuccessResult<?>> getPeople(
+    public ResponseEntity<ApiSuccessResult<PeopleDetailResponse>> getPeople(
         @AuthenticationPrincipal final PrincipalDetails principalDetails,
         @PathVariable final Long peopleId
     ) {

diff --git a/...in/java/es/princip/getp/persistence/adapter/like/people/PeopleLikePersistenceAdapter.java b/...in/java/es/princip/getp/persistence/adapter/like/people/PeopleLikePersistenceAdapter.java
@@ -54,8 +54,8 @@ public boolean existsBy(final MemberId memberId, final PeopleId peopleId) {
     }
 
     @Override
-    public Boolean existsBy(Member member, PeopleId peopleId) {
-        if (member.isPeople()) {
+    public Boolean existsBy(final Member member, final PeopleId peopleId) {
+        if (member == null || member.isPeople()) {
             return null;
         }
         return existsBy(member.getId(), peopleId);

diff --git a/.../java/es/princip/getp/persistence/adapter/like/project/ProjectLikePersistenceAdapter.java b/.../java/es/princip/getp/persistence/adapter/like/project/ProjectLikePersistenceAdapter.java
@@ -30,14 +30,11 @@ public void delete(final ProjectLike projectLike) {
     }
 
     @Override
-    public Boolean existsBy(final Member member, ProjectId projectId) {
+    public Boolean existsBy(final Member member, final ProjectId projectId) {
         if (member == null || member.isClient()) {
             return null;
         }
-        return repository.existsByMemberIdAndProjectId(
-            member.getId().getValue(),
-            projectId.getValue()
-        );
+        return existsBy(member.getId(), projectId);
     }
 
     @Override
@@ -57,7 +54,7 @@ public ProjectLike loadBy(final MemberId memberId, final ProjectId projectId) {
     }
 
     @Override
-    public boolean existsBy(MemberId memberId, ProjectId projectId) {
+    public boolean existsBy(final MemberId memberId, final ProjectId projectId) {
         return repository.existsByMemberIdAndProjectId(
             memberId.getValue(),
             projectId.getValue()