refacto(api): change the uri to respect the adr #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tleon
commented
Nov 29, 2023
tleon
commented
| Questions | Answers |
|---|---|
| Branch? | dev |
| Description? | Fix the URI paths in order for them to respect the ADR |
| Type? | refacto |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | CI 🟢 & UI tests 🟢 |
| UI Tests | |
| Fixed issue or discussion? | Fixes #34493 |
| Sponsor company | PrestaShop SA |
M0rgan01
reviewed
Nov 29, 2023
There was a problem hiding this comment.
I find it strange to have camelcase in an API, in general it is rather advisable to have kebab-case in a URL. For example, Google better indexes URLs containing kebab case
Consider using hyphens to separate words in your URLs, as it helps users and search engines identify concepts in the URL more easily. We recommend that you use hyphens (-) instead of underscores (_) in your URLs.
https://developers.google.com/search/docs/crawling-indexing/url-structure
|
https://github.com/PrestaShop/ADR/pull/35/files |
|
I know, but I just find it strange :) |
tleon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.