Endpoint Uninstall module #35
Conversation
dylanDenizonPresta
commented
Oct 23, 2024
dylanDenizonPresta
commented
| Questions | Answers |
|---|---|
| Description? | Endpoint Uninstall module |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | ~ |
| Sponsor company | ~ |
| How to test? | ~ |
| $module = [ | ||
| 'technicalName' => 'bankwire', | ||
| 'deleteFile' => false | ||
| ]; |
There was a problem hiding this comment.
No need for this variable, you can hard-code the value in your request parameter
| ]); | ||
|
|
||
| self::assertResponseStatusCodeSame(204); | ||
|
|
There was a problem hiding this comment.
You should use getModuleInfos to check the updated status of the module
| ]); | ||
|
|
||
| self::assertResponseStatusCodeSame(204); | ||
| } |
There was a problem hiding this comment.
You should check that now the API returns a 404 error code when we fetch the module's infos, maybe it's worth adding a checkModuleNotFound method similar to getModuleInfos except it returns void and it checks for the 404 error code
This can be reused in other test methods
There was a problem hiding this comment.
Since there is now a test that removes some module files we should integrate the ResourceResetter in the tear down method of this test, so that everything is restored at the end of the tests
|
Closed in favor of #37 |
