Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 in the base docker images #356

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Nov 7, 2023

Questions Answers
Description? Add PHP 8.3 in the base docker images so that they can be used for UI tests and sanity tests
To generate the base images we updated the tags.txt file and then we ran the base/generate_tags.sh -f (-f important o update all the bases) script so that it generates the base files based on the model
The we added the 8.3 version for nightly only (version 9.0 under development) and used the ./prestashop_docker.py generate script to generate its docker files
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company ~
How to test? ~

@jolelievre jolelievre changed the title Add PHP 8.3 in the base docker images so that they can be used for UI… Add PHP 8.3 in the base docker images Nov 7, 2023
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there's a problem logging with docker hub, it's expecting a nickname and password

Copy link

@tleon tleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the problems on the CI because this is on a fork ?

@jolelievre
Copy link
Contributor Author

@tleon yes they are, the publication cannot work on my fork because I don't have the secrets defined to push, we should probably change the workflows a bit so that they only run on merged PR it's not very useful o run this on each PR it could even be dangerous as it could push some non validated PR towards Docker

But the addition of 8.3 version is temporarily paused We have some bugs in the BO that are cause by Symfony, it's more efficient to wait for a few weeks for them to fix them, especially since we're gonna upgrade to SF6 that also should include some improvements for recent versions of PHP

@jolelievre jolelievre marked this pull request as draft November 21, 2023 09:29
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking to add PHP 8.3 today, but it appears you bring the same changes here

@jolelievre jolelievre merged commit b6a4724 into PrestaShop:master Feb 20, 2024
2 checks passed
@jolelievre jolelievre deleted the php83 branch June 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants