Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config file for SonarQube #1015

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add config file for SonarQube #1015

wants to merge 2 commits into from

Conversation

Quetzacoalt91
Copy link
Member

Questions Answers
Description? Add a configuration to prevent noise flooding our reports, such as the detection of duplicated code in tests or other places where this kind of contents is allowed and even expected.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? SonarQube is still able to run checks on the branch. Additional commits will be added to check how the configuration is now taken in account.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Nov 15, 2024
@Quetzacoalt91 Quetzacoalt91 force-pushed the add-sonarcloud-config branch 10 times, most recently from 036fd83 to 887aef2 Compare November 15, 2024 12:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
87.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Quetzacoalt91 Quetzacoalt91

Labels
enhancement invalid wip
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quetzacoalt91 @M0rgan01