Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds non-periodic ("outflow") case for 2D Burgers' #169

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

cwentland0
Copy link
Collaborator

Implements a 2D Burgers' case which features homogeneous Dirichlet BCs on the bottom and left boundaries, and homogeneous Neumann BCs on the top and right boundaries. This allows the Gaussian pulse IC to advect out of the domain, rather than following the previously-fixed periodic BCs. This case is largely just to simplify the Schwarz work, but also makes the 2D Burgers' case more generic. Also, this PR:

  • Updates the problem constructors to follow the more generic "create_problem_eigen" format
  • Adds the more generic problem parameterization that has been implemented for 2D Euler and 2D SWE
  • Adds all necessary mechanisms for 2D Burgers Schwarz coupling
  • Adds relevant tests for new case

@cwentland0 cwentland0 requested a review from fnrizzi January 24, 2025 20:25
@cwentland0 cwentland0 marked this pull request as draft January 24, 2025 21:22
@cwentland0 cwentland0 marked this pull request as ready for review January 27, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant