fix: #297 清除缓存功能失效 #326
Merged
fix: #297 清除缓存功能失效 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看上去不错，我们这里是否应该把删除缓存目录的操作放置在 try-catch 结构体中来捕获可能的错误 |
调用 _clearCache 的方法那里已经有 try-catch 了，所以就暂时没在这里加了，需要的话，我觉得可以加上 |
|
啊，没仔细看，抱歉。 感谢你的工作。 我会在 CI 通过后合并这个PR。 |
没事 哈哈 很棒的项目～感谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #297
通过删除缓存目录的方式实现清除缓存的方式
CachedNetworkImage version 2.3 版本之后原本的
emptyCache失效只能通过 CachedNetworkImage 自带的
.evictFromCache(url)去实现，不过当前项目要是需要记录所有的 url 改动有点大，折中方案的话，可以直接删除整个缓存目录