Add episodeName to hive to display it in history card #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的工作，不过这个PR会导致一些问题。 .g.dart 文件主要是模板代码，应该从对应的 .dart 文件根据注解自动生成，而不是自行修改。 在修改完对应的 .dart 文件后在终端运行 dart run build_runner build 以执行自动生成。 这个PR修改了自动生成的代码，后导致后续的自动生成出现问题。这里的最佳实践是，因为我们需要自定义 HistoryAdapter 。故此类不再适合自动生成，我们需要将对应的 HistoryAdapter 类从 .g.dart 中移动到 .dart 中，并移除 .dart 中Hisotry类的 @HiveType 注解以防止自动生成新的 HistoryAdapter 。 听上去似乎有些复杂? 如果觉得有些混乱的话，这个修改可以后续由我来进行。 |
|
就像我最新提交的这样吗？现在的 另外给macOS增加了允许播放http视频源的设置，避免部分视频无法在macOS上播放 |
|
看上去没有太大的问题，不过要通过运行过 dart run build_runner build 来修改 .g.dart 而不是手动移除对应代码。 这样可以确定当前修改没有损坏代码生成器。 |
|
此外我们可以修改一下 history_page 来让 episodeName 为空时以以前的格式显示进度，而不是留空 |
|
的确 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新旧版本hive结构互相兼容，新版本在旧版本上显示第几话，旧版本在新版本上显示相同，点开播放后恢复原始网页表现形式。
增加允许macOS播放http视频源设置，iOS已经允许不需要做改动