refactor: simplify functions in the "hoist from selected fields" process

PostgREST · Aug 21, 2024 · 2302f78 · 2302f78
1 parent e9244f1
commit 2302f78
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/PostgREST/Plan.hs b/src/PostgREST/Plan.hs
@@ -703,14 +703,12 @@ hoistFromSelectFields relAggAlias fields =
       let (modifiedField, maybeAgg) = modifyField field
       in (modifiedField : newFields, maybeAgg : aggList)
 
-    modifyField field =
-      case csAggFunction field of
-        Just aggFunc ->
-          ( field { csAggFunction = Nothing, csAggCast = Nothing },
-            Just ((relAggAlias, determineFieldName field), (aggFunc, csAggCast field, csAlias field)))
-        Nothing -> (field, Nothing)
-
-    determineFieldName field = fromMaybe (cfName $ csField field) (csAlias field)
+    modifyField field@CoercibleSelectField{csAggFunction=Just aggFunc, csField, csAggCast, csAlias} =
+      let determineFieldName = fromMaybe (cfName csField) csAlias
+          updatedField = field {csAggFunction = Nothing, csAggCast = Nothing}
+          hoistedField = Just ((relAggAlias, determineFieldName), (aggFunc, csAggCast, csAlias))
+      in (updatedField, hoistedField)
+    modifyField field = (field, Nothing)
 
 -- Taking the hoisted aggregates, modify the rel selects to apply the aggregates,
 -- and any applicable casts or aliases.