Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Fixed bug in RTL where the pin content was mirrored and unreadable #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yosilevy
Copy link

@yosilevy yosilevy commented Jan 14, 2019

Before fix (look at the pin):
slider-pin-before

After fix (ignore the number mismatch below - it's because of the screen cap)
slider-pin-after

@yosilevy yosilevy requested a review from e111077 as a code owner January 14, 2019 09:13
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@yosilevy
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@e111077
Copy link
Contributor

e111077 commented Jan 14, 2019

pending internal testing

@e111077
Copy link
Contributor

e111077 commented Jan 15, 2019

This unfortunately breaks YouTube. Looking into this a bit more to see if I can give any actionable advice

@e111077
Copy link
Contributor

e111077 commented Jan 15, 2019

Your code seems fine; it looks like it's a bug with our internal CSS builder. Unfortunately this means that I cannot merge this until we resolve this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants