Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Knob mixin #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

edu-aguilar
Copy link

added needed mixins to style the component from outside.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@edu-aguilar
Copy link
Author

I signed in cla.developers.google

@googlebot
Copy link

CLAs look good, thanks!

@keanulee
Copy link
Contributor

Hi @edu-aguilar , can you give some use cases on how these mixins will be used? Adding unnecessary mixins to the implementation of an element defeats the purpose of encapsulating implementation details.

@edu-aguilar
Copy link
Author

edu-aguilar commented Feb 2, 2017

hi @keanulee first of all, thanks for your fast reply. Im working in a component that wraps this one and i need those mixins to apply styles from outside. Specially, to remove margins that I dont need and set a custom height and width to knob.

I think this could be useful for other devs =)

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants