Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#170 Ensure checked has a default value of false if not set #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#170 Ensure checked has a default value of false if not set #171

wants to merge 1 commit into from

Commits on Feb 28, 2017

  1. PolymerElements#170 Ensure checked has a default value of false if no… 

    …t set

There is a known bug where when checked is bound to in a template value it's default value when unset is 'undefined' which results in the essential _compute functions not being called. Thus the hidden class (most importantly) is not defined and the default checkbox remains visible within the paper-checkbox location resulting in very bad UX.

This is probably a very inefficient method but.... it works. And doesn't loop so it's a start at least. And because it doesn't rely on passing itself into a computed function, it is still called when it's undefined and thus solves the primary problem indicated in PolymerElements#170
    @azariah001
    azariah001 authored Feb 28, 2017
    Configuration menu
    Copy the full SHA
    864fed0 View commit details
    Browse the repository at this point in the history