Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

fix: on-change event in shadowRoot #122

Closed
wants to merge 4 commits into from
Closed

fix: on-change event in shadowRoot #122

wants to merge 4 commits into from

Conversation

alimd
Copy link

@alimd alimd commented Jul 10, 2018

As you know, In the Shadow DOM, the change event is not leaked into the ancestor tree, so we must do this manually.
This is done in the rest of the input components by paper-input-behavior.

Fixed PolymerElements/paper-input#664

@alimd alimd requested a review from notwaldorf as a code owner July 10, 2018 08:27
@alimd
Copy link
Author

alimd commented Jul 10, 2018

@notwaldorf We have an issue in our app and need to fix it as soon as possible
Could you please review/merge this PR with priority
Thank you in advance.

@alimd
Copy link
Author

alimd commented Jul 10, 2018

travis error is not related to this PR changes!

@notwaldorf
Copy link
Contributor

The travis error is actually related to this PR: it says `Typings are stale. Please run "npm run update-types". You've added a new event type, which needs to be typed :)

Please update the types, then this should be good to merge

Copy link
Contributor

@notwaldorf notwaldorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(you need to update the typings)

@alimd
Copy link
Author

alimd commented Aug 7, 2018

@notwaldorf
Oops!
Excuse me.

@alimd
Copy link
Author

alimd commented Aug 7, 2018

Why issue remains?!

@alimd
Copy link
Author

alimd commented Aug 7, 2018

@notwaldorf
I fix the generated declaration manually, but could you please check this issue for future PR?

My generated declaration
interface IronAutogrowTextareaElement extends Polymer.IronValidatableBehavior, Polymer.IronControlState, Polymer.LegacyElementMixin, HTMLElement {

Travise
interface IronAutogrowTextareaElement extends Polymer.Element, Polymer.IronValidatableBehavior, Polymer.IronControlState {

https://travis-ci.org/PolymerElements/iron-autogrow-textarea/builds/413055027?utm_source=github_status&utm_medium=notification

@notwaldorf
Copy link
Contributor

cc @bicknellr for a release

@alimd alimd closed this by deleting the head repository Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants