Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Japanese data for Pokémon 960 and add Korean data, add missing Korean data(899 ~ 1025), add new Pokémon 1025 Korean data #1123

Merged

Conversation

BearHumanS
Copy link
Contributor

@BearHumanS BearHumanS commented Aug 30, 2024

Summary

This pull request contains some important updates and modifications to Pokémon data.

Changes made to:

  1. Correction of Japanese data:

    • Issue: Korean species name of Pokémon 960 is incorrectly recorded in Japanese.
    • Fix: We modified the Japanese data of Pokémon 960 from that dataset and added Korean data.
  2. Added missing Korean data:

    • Issue: Some Korean names of Pokémon species are missing. 899 to 1025
    • Update: Added missing Korean names to the Pokémon Species dataset.
  3. Add new Pokemon data:

    • Issue: Korean name and species of Pokémon 1025 are missing.
    • Update: Added Korean name and species for Pokémon 1025.

Updated files:

  • 'pokemon_species_names.csv'

Reasons for change

These updates improve the accuracy of Pokémon data and ensure that all related names are available to both Korean and Japanese users. The addition of Pokémon 1025 keeps the dataset up to date with new entries.

Test

  • I checked the accuracy of the modified name and the newly added Pokémon data.

Additional Notes

  • Please let me know if you have any further updates or issues.

스크린샷 2024-08-30 192153
image
image
image

@BearHumanS BearHumanS changed the title Fix Japanese Names for Pokémon 960, Add Missing Korean Data, and Include New Pokémon 1025 Modify Japanese data for Pokémon 960 and add Korean data, add missing Korean data, add new Pokémon 1025 Korean data Aug 30, 2024
@BearHumanS BearHumanS changed the title Modify Japanese data for Pokémon 960 and add Korean data, add missing Korean data, add new Pokémon 1025 Korean data Modify Japanese data for Pokémon 960 and add Korean data, add missing Korean data(899 ~ 1025), add new Pokémon 1025 Korean data Aug 30, 2024
@Naramsim
Copy link
Member

Thanks a lot for the PR! I'll look into it!

@BearHumanS
Copy link
Contributor Author

Thanks a lot for the PR! I'll look into it!

I'm happy to be able to contribute a little to this.

@Naramsim Naramsim merged commit fec1f2a into PokeAPI:master Aug 31, 2024
4 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants