Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exit handling + hook library change #4993

Merged
merged 10 commits into from
Jan 7, 2024
Merged

Conversation

artdeell
Copy link
Member

No description provided.

Now it does not look like dog poo
- Renamed class to MinecraftDownloader
- Shrunk download buffer to 32k
- Made DownloaderTask private and final
- Moved directory ensurement to the scheduling step, to avoid race conditions
- Fixed broken asset downloads for 1.6.x
- Replaced xhook with bytehook
- Reimplemented the exit hook and atexit()
@artdeell artdeell merged commit 01fb9ac into v3_openjdk Jan 7, 2024
2 checks passed
@artdeell artdeell deleted the rep/bytehook branch May 1, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant