Add partial CLN support with potential for other node types in the future #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds partial support for CLN:
CLN still doesn't store TLVs when storing invoices and payments (see ElementsProject/lightning#4470). However, they do now store a copy of the TLV into the description field of keysend invoices. They don't do the same for payments, unfortunately. This PR pulls out the boost info from the description field displays it to the user.
Full TLV support could be added through a CLN plugin like the following: https://github.com/cnixbtc/cln-podcast-payments . The interface could recommend this for users who want to see the sent boosts.
Adds generic LNClient trait and structures
Moves LND-specific code to LNDClient and adds a generic LNClient trait and structs that are implemented by LNDClient, CLNClient, and potentially others in the future.
Related: #70