Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update home.js #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamescridland
Copy link
Contributor

Limit podcast episode titles to one line. A small change alongside patch-4 (which I'm not clever enough to know how to combine in the web version of Github).

Limit podcast episode titles to one line
@valcanobacon
Copy link
Contributor

What do you mean limit to one line? does it cut off the message? Do you have a picture which illustrates it?

@jamescridland
Copy link
Contributor Author

Here's what it can look like if you have overly long podcast episode titles.

Screen Shot 2022-01-12 at 4 07 50 pm

This patch adds an overflow-ellipsis and limits episode titles (only) to one line-height. It has no effect on the message below.

Screen Shot 2022-01-12 at 4 11 00 pm

It is assumed that podcasters will have episode titles that can be told apart from the first 30-40 characters; it would be very poor practice were they not to in any case (for typical podcast apps only show 30-40 characters).

@jamescridland jamescridland mentioned this pull request Jan 12, 2022
@valcanobacon
Copy link
Contributor

valcanobacon commented Jan 12, 2022

That is an improvement! Is there a way to see the entire title? perhaps by hovering over it? Curious how you would implement that? Would a click to expand be better?

@jamescridland
Copy link
Contributor Author

You can relatively simply add a 'hover' action, but that doesn't work on mobile. It's also not very accessible.

This title has been set by the podcaster that is reading these boosts; and the first 30-40 characters should be enough to make the episode clear. If you'd be able to clarify the usecase for seeing the full episode title, I'd be grateful.

@valcanobacon
Copy link
Contributor

I guess as long as you can identify which episode it is that should be enough. It does seem unlikely that 30-40 characters would not be enough to identify the podcast. I suppose someone might want to read the title. What is the canonical mobile alternative to tooltips on hover?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants