Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend - tab 9 : hierarchy error displays #88

Closed

Conversation

JulienCorny
Copy link
Contributor

Correction and improvement of 400 and 404 errors in frontend tab 9 (hierarchy) :

  • remove error 400 duplicates (add "not-to-handle" in the header of getHierZh() )
  • improve error display when :
    • ZH does not belong to any river basin
    • ZH belongs to a river basin but this river basin does not have any rules
    • ZH belongs to a river basin which has rules, but the SDAGE of the ZH is wrong (= this SDAGE is not part of this river basin rules)

image

image

image

@edelclaux
Copy link
Contributor

woooow ! C'est dommage que le lint frontend marche pas :D

@JulienCorny JulienCorny force-pushed the fix/hierarchy_error_display branch from c96aa3f to 0da6603 Compare September 13, 2024 09:32
@edelclaux
Copy link
Contributor

Au niveau du rapport, on observe l'ancien comportement: le nom du bassin versant n’apparaît pas, et le tableau est affiché. Je propose les modifs suivantes:

Service hierarchy

On change getHierarchy par fetchHierarchy (plus juste). On ajoute un ou deux types par ci par la.
On évite la double assignation de setItems.
On renomme setItems en setHierarchyModel
Et hop.

image

Composant hierarchy

On enlève @input data, vu qu'on s’appuie sur le service.

image

image

Composant détails

On ajuste avec la suppression du paramètre.

image

image

Branche dédiée

J'ai mis ces changements que je propose dans une branche:

https://github.com/naturalsolutions/gn_module_ZH/tree/fix/hierarchy_error_display_ETIENNE

A vori si ça te parait ok !

@edelclaux
Copy link
Contributor

Ce problème a en fait été traitée dans une autre PR.

@edelclaux edelclaux closed this Sep 27, 2024
@JulienCorny JulienCorny deleted the fix/hierarchy_error_display branch January 10, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants