Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove "angular2-multiselect" and "ng-multiselect-dropdown" dependency #66

Merged

Conversation

edelclaux
Copy link
Contributor

@edelclaux edelclaux commented Apr 30, 2024

Périmètre Frontend > menu déroulant

Le travail dans cette PR a consisté à:

  • la création d'un composant zh-multiselect basé sur pnx-multiselect
  • le remplacement des différentes occurences de angular2-multiselect par zh-multiselect
  • le remplacement des différentes occurences de ng-multiselect-dropdown par zh-multiselect
  • le nettoyage de _app.modules.scss, node_modules, package.json, package-lock.json

Un soucis particulier a été porté à l'apparence de ce menu déroulant, afin de se rapprocher de ceux remplacés.

select single:
image

select multiple:
image

select multiple: search + select all
image

@edelclaux edelclaux self-assigned this Apr 30, 2024
@edelclaux edelclaux force-pushed the feat/remove-angular2-multiselect branch from 40b582c to 103caaf Compare May 3, 2024 08:03
@edelclaux edelclaux marked this pull request as ready for review May 3, 2024 16:05
@edelclaux edelclaux force-pushed the feat/remove-angular2-multiselect branch from 103caaf to 4ac157c Compare May 23, 2024 08:28
@edelclaux edelclaux merged commit 3677661 into PnX-SI:develop May 23, 2024
2 checks passed
@edelclaux edelclaux deleted the feat/remove-angular2-multiselect branch May 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant