GenericQuery: fix bug negative limit #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #51 +/- ##
========================================
Coverage 82.72% 82.72%
========================================
Files 4 4
Lines 272 272
========================================
Hits 225 225
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacquesfize
reviewed
Apr 8, 2024
src/utils_flask_sqla/generic.py
Outdated
| @@ -255,7 +254,7 @@ def raw_query(self, process_filter=True, with_limit=True): | |||
| unordered_q = self.build_query_filters(q, self.filters) | |||
| q = self.build_query_order(unordered_q, self.filters) | |||
|
|
|||
| if self.limit != -1 and with_limit: | |||
| if self.limit != -1: | |||
There was a problem hiding this comment.
Suggested change
| if self.limit != -1: | |
| if self.limit >0: |
|
Tu fais la modification ou je la fais ? Si je la fais, il faudrait que tu me donnes les droits. |
added 2 commits
April 17, 2024 23:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il me semble qu'il y a un bug entre la version 0.3.3 et la version 0.4.1 quand on utilise limit=-1 dans la GenericQuery :
{"code": 500, "description": "(psycopg2.errors.InvalidRowCountInLimitClause) LIMIT must not be negative}
J'ai ce bug quand je clique sur le bouton 'générer la liste des espèces' (qui utilise Generic Query) dans le module zones humides (onglet 5) lorsque la version de Utils-Flask-SQLAlchemy est 0.4.1 mais pas lorsque qu'elle est en 0.3.3.
Voici une proposition de correction avec suppression de l'argument with_limit. J'ai peut-être manqué quelque chose mais je ne comprends pas vraiment en quoi cet argument est utile ? Si limit=-1 de toute façon il n'y a pas de limite et sinon on renseigne la limite souhaitée.