Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct area_name for communes #8

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

joelclems
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (18f4741) 80.96% compared to head (b8b837c) 80.86%.

Files Patch % Lines
...versions/fda887e7b578_correct_area_name_for_COM.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage    80.96%   80.86%   -0.11%     
===========================================
  Files           25       26       +1     
  Lines          888      899      +11     
===========================================
+ Hits           719      727       +8     
- Misses         169      172       +3     
Flag Coverage Δ
pytest 80.86% <72.72%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camillemonchicourt
Copy link
Member

Il faudrait surtout corriger le soucis à la source, non ?
Dans les fichiers qui viennent de l'IGN ou dans la manière dont on les intègre dans la BDD.
Car je ne suis pas certain que cela va corriger le soucis pour les nouvelles installations ?
Et car on aura à nouveau le soucis si on met à jour les communes depuis le référentiel IGN.

@joelclems
Copy link
Contributor Author

Ca va corriger le soucis pour les nouvelles installation et les anciennes (apres un geonature db autoupdate).
Cela n'empêche pas bien sur de corriger le fichier à la source qui contient les caractères ¼ et ½.

@jacquesfize jacquesfize merged commit d61d887 into develop Jan 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants