[IMPORT] check permission when habitat is imported on existing station #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we now check permissions on the latter
47 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/import #3209 +/- ##
===============================================
+ Coverage 83.52% 83.54% +0.01%
===============================================
Files 121 121
Lines 9548 9559 +11
===============================================
+ Hits 7975 7986 +11
Misses 1573 1573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ation_permissions`
bouttier
reviewed
Oct 10, 2024
| @@ -205,6 +216,18 @@ def station(datasets): | |||
| return station | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="function") | |||
| def station_other_dataset(datasets): | |||
There was a problem hiding this comment.
Suggested change
| def station_other_dataset(datasets): | |
| def station_stranger_dataset(datasets): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a new check to verify if a user got required permissions to import a new habitat in an existing station.