WIP: state: Record the list of packfiles created. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
mm/state_delete_snapshot
to
mm/state_improvement
February 4, 2025 20:17
mathieu-plak
force-pushed
the
mm/state_improvement
branch
from
4dc85b2 to
5ad353d
Compare
* When building a delta state, record the packfiles that were created as part of the process.
mathieu-plak
force-pushed
the
mm/state_packfiles_list
branch
from
2e5a6d6 to
0b7ecc6
Compare
* While here implement packfile listing in plakar info state
brmzkw
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a delta state, record the packfiles that were created as part of the process.
Warning this is based on state: Add DeleteSnapshot() operation #385 ...
Putting in draft because I'm wondering if we should record the packfiles under the umbrella of the state id (so in leveldb it would be packfile:<state_id>:, and the payload would contain the state id), to efficiently retrieve it (for example in plakar info state f00b4r). This would need quite a bit of refactoring though (we only assign an ID to the state at serialization time right now).