Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 18208 Ensure Excel conversion to CSV includes all data #215

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Oct 28, 2024

Converting from Excel to CSV was skipping a line of data in the case that NO HEADER was used.
This ensures we always read all data rows after figuring out the header. The result of the conversion ALWAYS has a header row.

Copy link

File Coverage
All files 38%
plaidcloud/utilities/analyze_table.py 36%
plaidcloud/utilities/bom.py 24%
plaidcloud/utilities/clean_files.py 28%
plaidcloud/utilities/connect.py 35%
plaidcloud/utilities/convert_encoding.py 31%
plaidcloud/utilities/data_helpers.py 26%
plaidcloud/utilities/frame_manager.py 19%
plaidcloud/utilities/pretty_size.py 91%
plaidcloud/utilities/query.py 21%
plaidcloud/utilities/sql_expression.py 85%
plaidcloud/utilities/sqlalchemy_functions.py 62%
plaidcloud/utilities/sqlalchemy_views.py 92%
plaidcloud/utilities/stringtransforms.py 76%
plaidcloud/utilities/udf.py 16%
plaidcloud/utilities/utility.py 19%
plaidcloud/utilities/xray.py 88%
plaidcloud/utilities/remote/dim_helpers.py 10%
plaidcloud/utilities/remote/dimension.py 32%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against cc29d05

@rad-pat rad-pat merged commit 6f42d08 into master Oct 28, 2024
4 checks passed
@rad-pat rad-pat deleted the sc-18208 branch October 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants