Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change distinct behaviour #203

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Change distinct behaviour #203

merged 1 commit into from
Sep 17, 2024

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Sep 16, 2024

Distinct on databases other than postgres is called on the whole select. Currently it raises a warning, but that will become an error in future. Call the SQLAlchemy without the column setting

Copy link

github-actions bot commented Sep 16, 2024

File Coverage
All files 39%
plaidcloud/utilities/analyze_table.py 36%
plaidcloud/utilities/bom.py 24%
plaidcloud/utilities/clean_files.py 28%
plaidcloud/utilities/connect.py 35%
plaidcloud/utilities/convert_encoding.py 31%
plaidcloud/utilities/data_helpers.py 26%
plaidcloud/utilities/frame_manager.py 19%
plaidcloud/utilities/pretty_size.py 91%
plaidcloud/utilities/query.py 21%
plaidcloud/utilities/sql_expression.py 85%
plaidcloud/utilities/sqlalchemy_functions.py 63%
plaidcloud/utilities/sqlalchemy_views.py 92%
plaidcloud/utilities/stringtransforms.py 76%
plaidcloud/utilities/udf.py 16%
plaidcloud/utilities/utility.py 19%
plaidcloud/utilities/xray.py 88%
plaidcloud/utilities/remote/dim_helpers.py 10%
plaidcloud/utilities/remote/dimension.py 32%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 25d9eb5

@rad-pat rad-pat merged commit af4b536 into master Sep 17, 2024
4 checks passed
@rad-pat rad-pat deleted the sc-17692 branch September 17, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants