Merge pull request #267 from PlaidCloud/simplify-diff

Simplify diff

.dockerignore

@@ -37,7 +37,6 @@
 **/.storybook/
 **/node_modules/
 
-kubernetes/
 tests/
 docs/
 install/

CHANGELOG.md

@@ -32,7 +32,7 @@ under the License.
 - [2.1.0](#210-thu-mar-16-211305-2023--0700)
 - [2.0.1](#201-fri-nov-4-103402-2022--0400)
 - [2.0.0](#200-tue-jun-28-085302-2022--0400)
-- [1.5.3](#153-thu-jan-5-150544-2023--0500)
+- [1.5.3 (LTS)](#153-thu-jan-5-150544-2023--0500)
 - [1.5.2](#152-wed-sep-14-171151-2022-0530)
 - [1.5.1](#151-thu-may-26-144520-2022-0300)
 - [1.5.0](#150-fri-apr-22-172330-2022--0400)
@@ -2829,7 +2829,7 @@ under the License.
 - [#20392](https://github.com/apache/superset/pull/20392) feat: setting limit value when Pie chart switches (@zhaoyongjie)
 - [#20373](https://github.com/apache/superset/pull/20373) feat: adding truncate metric control on timeseries charts (@zhaoyongjie)
 - [#20248](https://github.com/apache/superset/pull/20248) feat(explore): Implement viz switcher redesign (@kgabryje)
-- [#20113](https://github.com/apache/superset/pull/20113) feat(api): Added "kind" to dataset/`<pk>` endpoint (@reesercollins)
+- [#20113](https://github.com/apache/superset/pull/20113) feat(api): Added "kind" to dataset/<pk> endpoint (@reesercollins)
 - [#20299](https://github.com/apache/superset/pull/20299) feat(explore): Dataset Panel Options when Source = Query II (@lyndsiWilliams)
 - [#20320](https://github.com/apache/superset/pull/20320) feat: Databricks native driver (@betodealmeida)
 - [#20313](https://github.com/apache/superset/pull/20313) feat(explore): Denormalize form data in echarts, world map and nvd3 bar and line charts (@kgabryje)
@@ -3577,7 +3577,7 @@ under the License.
 - [#19242](https://github.com/apache/superset/pull/19242) fix: allow subquery in ad-hoc SQL (@lilykuang)
 - [#18926](https://github.com/apache/superset/pull/18926) fix(explore comma): make that the comma can be added by removing it from token separators… (@prosdev0107)
 - [#19234](https://github.com/apache/superset/pull/19234) fix: adhoc column in legacy chart (@zhaoyongjie)
-- [#19076](https://github.com/apache/superset/pull/19076) fix: allow to select `<NULL>` in a native filter single mode (@diegomedina248)
+- [#19076](https://github.com/apache/superset/pull/19076) fix: allow to select <NULL> in a native filter single mode (@diegomedina248)
 - [#19159](https://github.com/apache/superset/pull/19159) fix(select): make to consider the case sensitive in case of d3 format selector (@prosdev0107)
 - [#19139](https://github.com/apache/superset/pull/19139) fix: Popovers in Explore not attached to the fields they are triggered by (@diegomedina248)
 - [#19152](https://github.com/apache/superset/pull/19152) fix: auto-complete of tables and names are not working in SQL lab (@diegomedina248)

RELEASING/from_tarball_entrypoint.sh

@@ -19,10 +19,6 @@ set -ex
 
 echo "[WARNING] this entrypoint creates an admin/admin user"
 echo "[WARNING] it should only be used for lightweight testing/validation"
-if [ "$SUPERSET_TESTENV" = "true" ]
-then
-  echo "SUPERSET IS RUNNING IN TEST MODE"
-fi
 
 if [ -z "${SUPERSET_TESTENV}" ]; then
   echo "SUPERSET IS RUNNING IN TEST MODE"

UPDATING.md

@@ -119,8 +119,6 @@ assists people when migrating to a new version.
 - [22328](https://github.com/apache/superset/pull/22328): For deployments that have enabled the "THUMBNAILS" feature flag, the function that calculates dashboard digests has been updated to consider additional properties to more accurately identify changes in the dashboard metadata. This change will invalidate all currently cached dashboard thumbnails.
 - [21765](https://github.com/apache/superset/pull/21765): For deployments that have enabled the "ALERT_REPORTS" feature flag, Gamma users will no longer have read and write access to Alerts & Reports by default. To give Gamma users the ability to schedule reports from the Dashboard and Explore view like before, create an additional role with "can read on ReportSchedule" and "can write on ReportSchedule" permissions. To further give Gamma users access to the "Alerts & Reports" menu and CRUD view, add "menu access on Manage" and "menu access on Alerts & Report" permissions to the role.
 
-### Breaking Changes
-
 ### Potential Downtime
 
 - [21284](https://github.com/apache/superset/pull/21284): A change which drops the unused `dbs.allow_multi_schema_metadata_fetch` column via a (potentially locking) DDL operation.

devspace.yaml

@@ -11,17 +11,6 @@ images:
         - ${DEVSPACE_RANDOM}
     tags:
     - ${DEVSPACE_RANDOM}
-  events:
-    image: us-docker.pkg.dev/plaidcloud-build/us-plaidcloud/superset-events
-    preferSyncOverRebuild: true
-    build:
-      custom:
-        command: ./deploy
-        args:
-        - events
-        - ${DEVSPACE_RANDOM}
-    tags:
-    - ${DEVSPACE_RANDOM}
   node:
     image: us-docker.pkg.dev/plaidcloud-build/us-plaidcloud/superset-node
     preferSyncOverRebuild: true
@@ -50,15 +39,6 @@ deployments:
         pullSecret: gcr-key
       node:
         repository: us-docker.pkg.dev/plaidcloud-build/us-plaidcloud/superset-node
-      events:
-        repository: us-docker.pkg.dev/plaidcloud-build/us-plaidcloud/superset-events
-        tag: latest
-        pullPolicy: IfNotPresent
-        pullSecret: gcr-key
-        entrypoint:
-          - "entrypoint"
-          - "python"
-          - "/plaid/plaid/event_handler.py"
       init:
         enabled: false
         loadExamples: true
@@ -160,21 +140,6 @@ dev:
     localSubPath: ./superset-frontend/src
     containerPath: /app/superset-frontend/src
     disableDownload: true  
-  - imageName: events
-    labelSelector:
-      app: superset
-      component: superset-events
-    containerName: events
-    localSubPath: ./plaid
-    containerPath: /plaid/plaid
-    disableDownload: true
-    onUpload:
-      execRemote:
-        onBatch:
-          command: bash
-          args:
-          - -c
-          - "kill -HUP 1"
 ######################################################################################################
 # READ THIS:
 #   To set any variables with a source of `env`, copy the `.env-sample` file at the root of

docs/docs/installation/configuring-superset.mdx

@@ -27,7 +27,6 @@ ENV SUPERSET_CONFIG_PATH /app/superset_config.py
 Docker compose deployments handle application configuration differently.  See [https://github.com/apache/superset/tree/master/docker#readme](https://github.com/apache/superset/tree/master/docker#readme) for details.
 
 The following is an example of just a few of the parameters you can set in your `superset_config.py` file:
-
 ```
 # Superset specific config
 ROW_LIMIT = 5000
@@ -89,7 +88,7 @@ WTF_CSRF_EXEMPT_LIST = [‘’]
 
 #### Adding an initial SECRET_KEY
 
-Superset requires a user-specified SECRET_KEY to start up. This requirement was [added in version 2.1.0 to force secure configurations](https://preset.io/blog/superset-security-update-default-secret_key-vulnerability/). Add a strong SECRET_KEY to your `superset_config.py` file like:
+Superset requires a user-specified SECRET_KEY to start up.  This requirement was [added in version 2.1.0 to force secure configurations](https://preset.io/blog/superset-security-update-default-secret_key-vulnerability/).  Add a strong SECRET_KEY to your `superset_config.py` file like:
 
 ```python
 SECRET_KEY = 'YOUR_OWN_RANDOM_GENERATED_SECRET_KEY'
@@ -100,7 +99,7 @@ You can generate a strong secure key with `openssl rand -base64 42`.
 #### Rotating to a newer SECRET_KEY
 
 If you wish to change your existing SECRET_KEY, add the existing SECRET_KEY to your `superset_config.py` file as
-`PREVIOUS_SECRET_KEY = `and provide your new key as `SECRET_KEY =`. You can find your current SECRET_KEY with these
+`PREVIOUS_SECRET_KEY = `and provide your new key as `SECRET_KEY =`.  You can find your current SECRET_KEY with these
 commands - if running Superset with Docker, execute from within the Superset application container:
 
 ```python
@@ -128,14 +127,15 @@ Superset supports the following database engines/versions:
 
 Use the following database drivers and connection strings:
 
-| Database                                  | PyPI package              | Connection String                                                      |
-| ----------------------------------------- | ------------------------- | ---------------------------------------------------------------------- |
-| [PostgreSQL](https://www.postgresql.org/) | `pip install psycopg2`    | `postgresql://<UserName>:<DBPassword>@<Database Host>/<Database Name>` |
-| [MySQL](https://www.mysql.com/)           | `pip install mysqlclient` | `mysql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`      |
+| Database                                  | PyPI package                      | Connection String                                                        |
+| ----------------------------------------- | --------------------------------- | ------------------------------------------------------------------------ |
+| [PostgreSQL](https://www.postgresql.org/) | `pip install psycopg2`            | `postgresql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`   |
+| [MySQL](https://www.mysql.com/)           | `pip install mysqlclient`         | `mysql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`        |
 
 To configure Superset metastore set `SQLALCHEMY_DATABASE_URI` config key on `superset_config`
 to the appropriate connection string.
 
+
 ### Running on a WSGI HTTP Server
 
 While you can run Superset on NGINX or Apache, we recommend using Gunicorn in async mode. This

docs/docs/installation/running-on-kubernetes.mdx

@@ -147,7 +147,7 @@ connect to those datasources in your Superset installation:
 ```yaml
 bootstrapScript: |
   #!/bin/bash
-  pip install psycopg2==2.9.5 \
+  pip install psycopg2==2.9.6 \
     sqlalchemy-bigquery==1.6.1 \
     elasticsearch-dbapi==0.2.5 &&\
   if [ ! -f ~/bootstrap ]; then echo "Running Superset with uid {{ .Values.runAsUser }}" > ~/bootstrap; fi

docs/docs/security/security.mdx

@@ -1,5 +1,5 @@
 ---
-title: Role based Access
+title: Security
 hide_title: true
 sidebar_position: 1
 ---

helm/superset/values.yaml

@@ -43,15 +43,10 @@ serviceAccount:
 # @default -- see `values.yaml`
 bootstrapScript: |
   #!/bin/bash
-  # rm -rf /var/lib/apt/lists/* && \
-  # pip install \
-  #   psycopg2-binary==2.9.6 \
-  #   redis==3.5.3 && \
   if [ ! -f ~/bootstrap ]; then echo "Running Superset with uid {{ .Values.runAsUser }}" > ~/bootstrap; fi
 
-## The name of the secret which we will use to generate a superset_config.py file
-## Note: this secret must have the key superset_config.py in it and can include other files as well
-##
+# -- The name of the secret which we will use to generate a superset_config.py file
+# Note: this secret must have the key superset_config.py in it and can include other files as well
 configFromSecret: plaid-superset-config-override
 
 # -- The name of the secret which we will use to populate env vars in deployed pods