-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to view stash in status window and pop individual stash entries #88
base: main
Are you sure you want to change the base?
Conversation
@Piturnah |
TODOs (if this is something we want):
|
This is great, and is absolutely a needed feature in gex. I think it's worth considering an alternate flow that's more like the branch list, wherein you can press z for stash and then there's a subcommand that brings up the list of stashes. Here's my thinking for why this would be better:
The main downside I see here is that it brings the user experience further from Magit, which can be a pain point for users who are coming from there. It is explicit in the project readme that the goal is to not reproduce 1:1 magit behaviour, but I still think this point is worth bringing up (even if not given too much weight) Your idea to collapse the stash list by default is a good one that also helps with the decluttering, but if we're doing that then it seems to me like it is worth considering just putting it in a different view to get the searching upside What do you think? |
Agree that this is the right pattern for many reasons.
|
Hey @LukeHalasy, thanks again for the work here! Mind if I take over this PR and get it finished up? |
W.I.P Add stash abilities to gex (beyond the current stash commands)