Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the service calls to vacuum independent versions #114

Closed
wants to merge 1 commit into from

Conversation

halfbakery
Copy link

The current service call (vacuum.send_command) is highly vacuum specific. The xiaomi_miio integration supports vacuum independent calls, e.g. vacuum_clean_zone, vacuum_goto and vacuum_clean_segment (for future improvements).

I have an open PR nqkdev/home-assistant-vacuum-styj02ym#47 adding the same functionality to the Viomi/STYJ02YM driver. With these modifications, both vacuum families could be supported by the same codebase.

@HepoH3
Copy link
Contributor

HepoH3 commented Jul 5, 2021

With these modifications, both vacuum families could be supported by the same codebase.

You're really awesome!

I have an open PR nqkdev/home-assistant-vacuum-styj02ym#47 adding the same functionality to the Viomi/STYJ02YM driver.

Maybe you should open PR into the KrzysztofHajdamowicz fork? Original repo is pretty dead, there is a lot of opened PRs, while KrzysztofHajdamowicz keeps his fork alive.

@halfbakery
Copy link
Author

With these modifications, both vacuum families could be supported by the same codebase.

You're really awesome!

I have an open PR nqkdev/home-assistant-vacuum-styj02ym#47 adding the same functionality to the Viomi/STYJ02YM driver.

Maybe you should open PR into the KrzysztofHajdamowicz fork? Original repo is pretty dead, there is a lot of opened PRs, while KrzysztofHajdamowicz keeps his fork alive.

I've sent him a PR too:
KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym#12

@KrzysztofHajdamowicz
Copy link

I've sent him a PR too:
KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym#12

Thanks for this PR, it's merged a few seconds ago :)

@PiotrMachowski
Copy link
Owner

Handled in v2.0.0

@halfbakery
Copy link
Author

I've spent the last hour playing with your new vacuum card, it's awesome! :-)

@PiotrMachowski
Copy link
Owner

@halfbakery thank you! It required a looooooot of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants