test: improve stream checking

PhpGt · Sep 18, 2023 · 1565507 · 1565507
1 parent 42ca4a0
commit 1565507
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -19,7 +19,7 @@ class Application {
 	protected HelpCommand $helpCommand;
 	protected VersionCommand $versionCommand;
 	private int $exitCode;
-	/** @var callable */
+	/** @var ?callable */
 	private $exitHandler;
 
 	public function __construct(

diff --git a/test/phpunit/ApplicationTest.php b/test/phpunit/ApplicationTest.php
@@ -195,7 +195,7 @@ public function testCommandRun() {
 		);
 	}
 
-	public function testExitCodeNotEnoughArtguments() {
+	public function testExitCodeNotEnoughArguments() {
 		$parameter = self::createMock(NamedParameter::class);
 		$argumentsList = self::createMock(ArgumentList::class);
 		$argumentsList->method("getCommandName")
@@ -223,11 +223,17 @@ public function getOptionalParameterList():array { return []; }
 		};
 		$actualErrorCode = null;
 		$sut = new Application("Test app", $argumentsList, $command1);
+		$sut->setStream(
+			$this->inPath,
+			$this->outPath,
+			$this->errPath
+		);
 		$sut->setExitHandler(function(int $errorCode) use(&$actualErrorCode) {
 			$actualErrorCode = $errorCode;
 		});
 		$sut->run();
 		self::assertSame(1, $actualErrorCode);
+		self::assertStreamContains("Error: Not enough arguments passed. Passed: 0 required: 1.", Stream::ERROR);
 	}
 
 	protected function assertStreamContains(