-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add The Sims 2 #927
base: master
Are you sure you want to change the base?
Add The Sims 2 #927
Conversation
Merged current master
Update the fork with changes from master fork.
Fork update
merge changes
Merging changes to the fork
Merging updates from master fork
Merging changes from master
Why is there commits for atmlib despite it is already in the main repo ? |
@ImperatorS79 no idea why they are here since I've created this branch out of master not atmlib. There isn't a include for AppResource - just Resource but isn't that the same thing? |
Merge master branch
@Zemogiter You need to include utils.functions.apps.resources ! |
Added missing include
Removed accidential changes.
Despite Codacy having issues the installation went though and the game - against all odds - works just fine aside that it changes my display's resolution to 1024x768 and the files in |
Removal of unused includes.
You probably have to use something like |
Okay so I've played this game and the tree textures are white and Sims are red human-shaped t-posing polygons. I've tried Lutris script but the game installation crashes because of vcrun error. Changine wine version in Lutris dosen't help. We may need that patched wine from the OP after all. |
Trying to obtain username so that postInstall would work without user intervention. Untested.
A log from wine could be nice to debug. |
@Zemogiter Did you check WINEDEBUG ? Seems pretty empty ^^. |
WINEDEBUG is set in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong click the previous comments are change requests
Removing extra newlines
code clearup
Fixed name mismatch and indentation.
Using different link for fixes constant, moved the username constant up, added an env value.
Commenting out stuff related to regedit because I'm not sure if they are needed based on how Lutris script looks like.
Trailing spaces strike back!
Merge master fork
Made the script more similiar to Lutris one.
Extracting the fixes archive results in error:
|
This looks like a syntax error. Can you identify which of your two |
I have only one |
Your PR contains two |
I use |
If the |
Unable to test local installation.
Dosen't seem to be useful anymore
@plata you're correct |
What's the status now? Does it work? |
|
@Zemogiter I think you will need to try again with a "clean" script repository, |
@madoar still the same error happens at the exact same time |
After updating the local repo and the app and including #1198 and changing
|
As of right now the script crashes when trying to download the file infixes
variable.Because of that I was unable to go any further and test if the game works.Requesting the Help Needed label for the PR.Comparing to the Lutris script (https://lutris.net/games/install/8277/view) I've noticed we may need these things:
patched version of Wine (https://github.com/lah7/sims-2-wine-patches) because Wine have a hardcoded limit of vertex shaders. We can use the already compiled releases.May be no longer necesseary at least according to this: https://github.com/lah7/sims-2-wine-patches/blob/master/README-D9VK.mdset the WINE_LARGE_ADDRESS_AWARE to 1 (not sure if it's applied inwe have theetc/enviroment
or somewhere else but I think it's not a registry setting).environment
hook so that part is no longer revelantTL;DR
The game works but sims are displayed as red, T-posing models and textures of trees are white aka exploding textures. Tried DVK9 (crashes the game) and V9K (dosen't fix the issue).