Adapt project for Jazzmin Admin Template, added spanish language support #72
Conversation
|
@santiago1114 Thank you very much for your contribution. Could you please tak a look at the failing tests? |
| {% for chart in charts %} | ||
| {% include "./chart_container.html" with chart=chart %} | ||
| {% empty %} | ||
| <p> | ||
| No charts available, please <a href="{% url 'admin:admin_tools_stats_dashboardstats_changelist' %}">configure them</a> | ||
| {% trans "There aren't charts for display, please setup making" %}<a href="{% url 'admin:admin_tools_stats_dashboardstats_changelist' %}"> clic</a> |
There was a problem hiding this comment.
This sentence doesn't make sense. Word clic is a typo, untranslatable and I would prefer to follow UX best practices and put action name as the link text instead of using "click", "click here" or similar.
| {% csrf_token %} | ||
| {% for w in form %} | ||
| {% if not w.is_hidden %} | ||
| {{ w.label }}: | ||
| {% endif %} | ||
| {{ w }} | ||
| {% endfor %} | ||
| <button class="reload" id="reload" title="reload values from unfinished periods" type="button" style="font-size:14px">⟳</button> | ||
| <br> |
There was a problem hiding this comment.
Putting the reload button on newline might not be always the best option. For example if I have charts in two columns, it would result in this less compact layout with 3 row controls:
I don't think, that the controls layout is optimal, but I am not sure, if this change will make it better.
Also, if we are new line, you should remove the from the beginning of the line to align all elements at the start.
|
@santiago1114 Would you like to finish this PR, please? I have made some changes to the project, so this would need to be rebased to the current master. |
A pull request for update code for: