fix and test #71 (add view don't work on Django 5.0)

PetrDlouhy · Apr 12, 2024 · d6415ff · d6415ff
1 parent 1c6af55
commit d6415ff
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,11 @@
 Changelog
 =========
 
+1.3.1 (2024-04-12)
+------------------
+
+* fix for Django 5.0 DashboardStats admin add view
+
 1.3.0 (2023-02-10)
 ------------------
 

diff --git a/admin_tools_stats/admin.py b/admin_tools_stats/admin.py
@@ -86,9 +86,12 @@ def criteria__criteria_dynamic_mapping_preview(self, obj):
 class DashboardStatsForm(forms.ModelForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
-        self.fields["default_multiseries_criteria"].queryset = CriteriaToStatsM2M.objects.filter(
-            stats=self.instance,
-        )
+        if self.instance.pk:
+            self.fields["default_multiseries_criteria"].queryset = (
+                CriteriaToStatsM2M.objects.filter(
+                    stats=self.instance,
+                )
+            )
 
 
 @admin.register(DashboardStats)

diff --git a/admin_tools_stats/tests/test_admin.py b/admin_tools_stats/tests/test_admin.py
@@ -98,6 +98,14 @@ def test_admin_tools_stats_dashboardstatscriteria(self):
         response = self.client.get("/admin/admin_tools_stats/dashboardstatscriteria/")
         self.assertEqual(response.status_code, 200)
 
+    def test_add_view(self):
+        url = reverse("admin:admin_tools_stats_dashboardstats_add")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+        url = reverse("admin:admin_tools_stats_dashboardstatscriteria_add")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+
 
 class AdminToolsStatsAdminCharts(BaseSuperuserAuthenticatedClient):
     def test_admin_dashboard_page(self):