Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak 4.8 Support #36

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Keycloak 4.8 Support #36

wants to merge 5 commits into from

Conversation

Peter-Slump
Copy link
Owner

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #36 into develop will increase coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage     35.4%   35.54%   +0.14%     
===========================================
  Files           32       32              
  Lines          870      875       +5     
===========================================
+ Hits           308      311       +3     
- Misses         562      564       +2
Impacted Files Coverage Δ
src/django_keycloak/app_settings.py 100% <100%> (ø) ⬆️
src/django_keycloak/services/oidc_profile.py 69.07% <60%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5211fba...f3d8155. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@moezF
Copy link

moezF commented Nov 12, 2020

unsuccessful checks are related to django 1.1 which have reached it's end of life (not supported any more),
Entitlement API is deprecated in all keycloak version >= 4.8
i don't see a reason not to merge this pr and make a release

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.54%. Comparing base (5211fba) to head (f3d8155).

Files with missing lines Patch % Lines
src/django_keycloak/services/oidc_profile.py 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    35.40%   35.54%   +0.14%     
===========================================
  Files           32       32              
  Lines          870      875       +5     
===========================================
+ Hits           308      311       +3     
- Misses         562      564       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants