Fix extra call to archive/accept in Glam onboarding
#517
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original onboarding flow was designed to not accept an archive invitation until the end of the flow in case the user wanted to change which archive they accept. In the new "Glam" onboarding flow, the user can accept as many archives as they want in addition to creating an archive. Accepting archive invites also happens as soon as the user clicks accept on the first page, rather than at the end of onboarding. Since the Glam onboarding flow is still built on top of the older onboarding components, this final archive accepting stage still runs despite the fact that the invitations have been accepted. This causes a brief error message to appear before the user is directed to their archive. Only run this acceptance logic during the legacy onboarding flow so that this doesn't happen. This error could have been prevented if the "glam" onboarding was built separately from the previous onboarding flow. This has caused many of the recent onboarding issues in both Glam and original flows. PER-9971: Final onboarding screen triggers an error for invitation
meisekimiu
force-pushed
the
glam-duplicate-archive-accept
branch
from
9dbef9b to
207ff6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 43.44% 43.53% +0.09%
==========================================
Files 364 364
Lines 11178 11179 +1
Branches 1827 1828 +1
==========================================
+ Hits 4856 4867 +11
+ Misses 6159 6147 -12
- Partials 163 165 +2 ☔ View full report in Codecov by Sentry. |
crisnicandrei
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original onboarding flow was designed to not accept an archive invitation until the end of the flow in case the user wanted to change which archive they accept. In the new "Glam" onboarding flow, the user can accept as many archives as they want in addition to creating an archive. Accepting archive invites also happens as soon as the user clicks accept on the first page, rather than at the end of onboarding.
Since the Glam onboarding flow is still built on top of the older onboarding components, this final archive accepting stage still runs despite the fact that the invitations have been accepted. This causes a brief error message to appear before the user is directed to their archive. Only run this acceptance logic during the legacy onboarding flow so that this doesn't happen.
Steps to test:
This can also be tested in Storybook by comparing the mocked calls to
archive/accept, though this is more of a test for developers.