Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New least squares interface #88

Merged
merged 26 commits into from
Oct 30, 2024
Merged

New least squares interface #88

merged 26 commits into from
Oct 30, 2024

Conversation

LuEdRaMo
Copy link
Collaborator

@LuEdRaMo LuEdRaMo commented Oct 11, 2024 •
edited
Loading

This PR has two objectives:

  1. To rewrite the least squares code into a more organized and general interface.
  2. To implement Carpino et al. (2003) outlier rejection algorithm as part of the least squares iterations. This is done by updating the ideas of WIP: Reject outliers during orbital fit iterations (following Carpino et al. (2003)) #71 to the new orbit determination and least squares interfaces.

@LuEdRaMo LuEdRaMo marked this pull request as ready for review October 14, 2024 17:16
@LuEdRaMo LuEdRaMo force-pushed the lerm/leastsquares branch 2 times, most recently from 17b5d77 to 0ae02fd Compare October 19, 2024 17:46
@LuEdRaMo
New least squares interface
294ff4f
@LuEdRaMo
Carpino et al. (2003) outlier rejection
c0a3a07
@LuEdRaMo
Minor fixes
b125b3b
@LuEdRaMo
Introduce OutlierRejectionCache
6bbc0f3
@LuEdRaMo
Fix OD tests
9f73e45
@LuEdRaMo
Fix outlier rejection tests
2c7a77e
@LuEdRaMo
Fix B-plane tests
134663f
@LuEdRaMo
Temporarily set aqua ambiguity tests as broken
839ef08
@LuEdRaMo
Delete old least squares files
e2ab1cb
@LuEdRaMo
Fix outlier_rejection! export
855edaa
@LuEdRaMo
Update scripts/mcmov.jl
f871be5
@LuEdRaMo
Rename newtoniter -> lsiter in NEOParameters
a66a09d
@LuEdRaMo
Update scripts/orbitdetermination.jl
51c7484
@LuEdRaMo
Update scripts/adam.jl
6fadab3
@LuEdRaMo
Do not invert matrices with large conditioning number
3f68a91
@LuEdRaMo
Minor fix
3ad5932
@LuEdRaMo
Add filters to scripts/orbitdetermination.jl
4eb7faa
@LuEdRaMo
Fix scripts/orbitdetermination.jl
1eeda63
@LuEdRaMo
Move least squares methods constructors outside struct
9bdbd61
@LuEdRaMo
Update pha/apophis.jl
b0935a0
@LuEdRaMo
Test lu success instead of conditioning number
888ca4f
@LuEdRaMo
Minor fix in OutlierRejectionCache
6d06d9d
@LuEdRaMo
Update OD scripts
149cb5d
@LuEdRaMo
Copy link
Collaborator Author

I've tested both pha/apophis.jl and scripts/orbitdetermination.jl and the results from this PR are consistent with master. Therefore, I'll proceed to merge this.

@LuEdRaMo LuEdRaMo merged commit 012740b into main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LuEdRaMo