Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apophis script and some cleanup #29

Merged
merged 32 commits into from
Jul 17, 2023
Merged

Update Apophis script and some cleanup #29

merged 32 commits into from
Jul 17, 2023

Conversation

PerezHz
Copy link
Owner

@PerezHz PerezHz commented Jul 11, 2023

This PR updates the pha/apophis.jl script, and adds a Project.toml in the same pha folder to execute the script independently of the NEOs.jl environment. I've also taken the opportunity to do cleanup of some legacy code, and tried to fix #20 by going back to downloading MPC catalogue codes via HTTP.jl (similar to how it was originally done). Yet, there are still some issues related to windows testing of NEOs.jl via GHA CI, for which I don't have a quick fix right now.

@PerezHz
Copy link
Owner Author

PerezHz commented Jul 17, 2023

Tests are failing in nightly due to some issues with StaticArrays, but I suggest to wait a bit and see before taking action on this. Tests are also failing on windows, but that seems to be CI-related, since offline tests pass without any issue, as far as we've been able to test on different windows machines. Therefore, since we have passing tests on ubuntu and macos, I will go ahead and merge.

@PerezHz PerezHz merged commit 07e138f into main Jul 17, 2023
4 of 12 checks passed
@PerezHz PerezHz deleted the jp/various-fixes branch July 17, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurrent failure of observations tests due to timeout error in Windows
1 participant