Update Apophis script and some cleanup #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies" This reverts commit fa07964.
PerezHz
force-pushed
the
jp/various-fixes
branch
from
b73da42
to
a37a321
Compare
|
Tests are failing in nightly due to some issues with StaticArrays, but I suggest to wait a bit and see before taking action on this. Tests are also failing on windows, but that seems to be CI-related, since offline tests pass without any issue, as far as we've been able to test on different windows machines. Therefore, since we have passing tests on ubuntu and macos, I will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
pha/apophis.jlscript, and adds aProject.tomlin the samephafolder to execute the script independently of the NEOs.jl environment. I've also taken the opportunity to do cleanup of some legacy code, and tried to fix #20 by going back to downloading MPC catalogue codes via HTTP.jl (similar to how it was originally done). Yet, there are still some issues related to windows testing of NEOs.jl via GHA CI, for which I don't have a quick fix right now.