fix: joy_name indexes correctly referenced #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the automatic detection of controllers
find
returns the index of where the string was found in the word. Controllers were always defaulting to XBox if the match was at index 0. An example is thePS4 Controller
it was matching at index 0 on thejoy_name.find("PS")
criteria, so it was being classed as falsy and then falling through to theelse
.Example
PS4 Controller before fix:
PS4 Controller after fix: