-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ancilla
argument in iterative_qpe
#6532
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've left a couple of blocking comments. Happy to approve once resolved.
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6532 +/- ##
==========================================
- Coverage 99.65% 99.34% -0.32%
==========================================
Files 455 455
Lines 43193 43180 -13
==========================================
- Hits 43044 42896 -148
- Misses 149 284 +135 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments, otherwise ready to approve :)
Co-authored-by: Mudit Pandey <[email protected]>
…PennyLaneAI/pennylane into remove-ancilla-in-iterative-qpe
Context:
as title
Description of the Change:
Here are the occurrences I noticed to move:
qml.ops.functions.iterative_qpe.py
Benefits:
Possible Drawbacks:
Related GitHub Issues:
Related GitHub Issues:
[sc-77483]