Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ancilla argument in iterative_qpe #6532

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Nov 6, 2024

Context:
as title
Description of the Change:
Here are the occurrences I noticed to move:

  • src: qml.ops.functions.iterative_qpe.py
  • test of the src mentioned above

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Related GitHub Issues:
[sc-77483]

@JerryChen97 JerryChen97 marked this pull request as ready for review November 6, 2024 15:28
@JerryChen97
Copy link
Contributor Author

@lillian542 @mudit2812

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've left a couple of blocking comments. Happy to approve once resolved.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved
pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (e0949ed) to head (ab50948).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6532      +/-   ##
==========================================
- Coverage   99.65%   99.34%   -0.32%     
==========================================
  Files         455      455              
  Lines       43193    43180      -13     
==========================================
- Hits        43044    42896     -148     
- Misses        149      284     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments, otherwise ready to approve :)

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
tests/ops/functions/test_iterative_qpe.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants