-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial image links #151
Conversation
thanks @ottoak! @lillian542 looks like this package will need to be pinned to an earlier version of TF, since TF 2.13 is incompatible with PL 0.29 (which this package pins to). So we may need a new release of this plugin, with TF pinned |
Python doesn't really have a system for pinning optional dependencies, and I don't think we want to make TF a hard dependency. If the concern right now is the CI, we can pin the version in This long-standing problem of not knowing which combination of versions worked at a particular point in time will potentially be fixed by adding poetry support in the new year, but until then... I think the best we can do is update the requirements files. |
@albi3ro oops good point, I forgot TF was an optional dependency. In that case, should be fine to just pin it in thebCI requirements. Regarding RTDs, could we copy a RTDs config file from a more up to date plugin? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 498 498
=========================================
Hits 498 498 ☔ View full report in Codecov by Sentry. |
@josh146 @lillian542 @albi3ro This looks good to go now, but I don't have merge privileges - can one of you do so? |
Image links pointed to old locations in the QML repo and one was broken:
This PR fixes these links to point to the right locations